[debian-edu-commits] debian-edu/ 02/02: debian/control: use unversioned depends on the debian-edu-artwork* binary packages.

Discussion:

Mike Gabriel

2014-10-22 09:33:43 UTC

Permalink

Hi Holger,

This is an automated email from the git hooks/post-receive script.
holger pushed a commit to branch master
in repository debian-edu-artwork.
commit aef9ee78019fb922a1bbb8015c5d531b86d3b75b
Date: Tue Oct 21 18:17:38 2014 +0200
debian/control: use unversioned depends on the
debian-edu-artwork* binary packages.
(Originally to support binNMUs, but then I also couldn't see a
need for them
in the first place.)
---
debian/changelog | 7 +++++++
debian/control | 8 ++++----
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index f73d286..0a22150 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+debian-edu-artwork (0.50-2) UNRELEASED; urgency=medium
+
+ * debian/control: use unversioned depends on the
debian-edu-artwork* binary
+ packages.
+
+
debian-edu-artwork (0.50-1) unstable; urgency=medium
* media-cover: remove old artwork from 2007 (or before?) - we have shiny
diff --git a/debian/control b/debian/control
index 5c12dc1..dd93c55 100644
--- a/debian/control
+++ b/debian/control
git://anonscm.debian.org/debian-edu/debian-edu-artwork.git
Package: debian-edu-artwork
Architecture: all
Depends: ${misc:Depends},
- debian-edu-artwork-lines (= ${binary:Version}) |
debian-edu-artwork-joy (= ${binary:Version}) |
debian-edu-artwork-spacefun (= ${binary:Version}),
+ debian-edu-artwork-lines | debian-edu-artwork-joy |
debian-edu-artwork-spacefun,
desktop-base,
libconfig-inifiles-perl,
libglib2.0-bin,
@@ -41,7 +41,7 @@ Description: Debian Edu themes and artwork
Package: debian-edu-artwork-lines
Architecture: all
Depends: ${misc:Depends},
- debian-edu-artwork (= ${binary:Version}),
+ debian-edu-artwork,
Breaks: debian-edu-artwork (<< 0.46~)
Replaces: debian-edu-artwork (<< 0.46~)
Description: Debian Edu Lines (jessie) themes and artwork
@@ -53,7 +53,7 @@ Description: Debian Edu Lines (jessie) themes and artwork
Package: debian-edu-artwork-joy
Architecture: all
Depends: ${misc:Depends},
- debian-edu-artwork (= ${binary:Version}),
+ debian-edu-artwork,
Breaks: debian-edu-artwork (<< 0.46~)
Replaces: debian-edu-artwork (<< 0.46~)
Description: Debian Edu Joy (wheezy) themes and artwork
@@ -65,7 +65,7 @@ Description: Debian Edu Joy (wheezy) themes and artwork
Package: debian-edu-artwork-spacefun
Architecture: all
Depends: ${misc:Depends},
- debian-edu-artwork (= ${binary:Version}),
+ debian-edu-artwork,
Breaks: debian-edu-artwork (<< 0.46~)
Replaces: debian-edu-artwork (<< 0.46~)
Description: Debian Edu Spacefun (squeeze) themes and artwork

Please revert this change. Or at least use

Depends: debian-edu-artwork (>= ${source:Version}),
debian-edu-artwork (<< ${source:Version}.1)

There are places in the debian debian-edu-artwork source package that
causes a strict versioned dependency between the common
debian-edu-artwork bin:package and the theme bin:packages
debian-edu-artwork-<theme>.

Please ask before committing such changes.

Thanks,
Mike
--
DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: ***@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

Holger Levsen

2014-10-22 09:58:17 UTC

Permalink

Hi Mike,

Post by Mike Gabriel
Please revert this change. Or at least use
Depends: debian-edu-artwork (>= ${source:Version}),
debian-edu-artwork (<< ${source:Version}.1)
There are places in the debian debian-edu-artwork source package that
causes a strict versioned dependency between the common
debian-edu-artwork bin:package and the theme bin:packages
debian-edu-artwork-<theme>.

I've seen that, discussed it (even highlighted you in that discussion),
thought about it and didnt find any valid reason to have these in place.
Please explain why they are needed.

(Oh, and the reason I noticed was that I noticed that the relationship was =
and not >=, which is broken, as it breaks binNMUs. (Which given the way the
package builds, might actually be needed...))

So my changed *fixed* something.

Post by Mike Gabriel
Please ask before committing such changes.

Please explain when asking for doing changes ;-P

[18:18] < h01ger> | schweer: sunweaver: or could you see any reasons why
there should be versioned depends?
[18:44] < schweer> | h01ger: unsure, the versioned depends are due to
sunweaver.
[18:45] < h01ger> | i'd understand versioned depends on an specific
version
[18:45] < h01ger> | but on the latest, always? thats already the default
[18:45] < schweer> I guess that's unneeded.
[18:45] < h01ger> | so its just really needed, if it absolutly must be
met, for example for libraries, compilers, data, whatever
[18:46] < h01ger> | but d-e-a-$foo > 0.50 will work nicely with d-e-a a
version less
[18:46] < h01ger> | as i see things
[18:47] < schweer> yes.
[19:12] < h01ger> | so that cleanup was good

So again: why?

cheers,
Holger

Mike Gabriel

2014-10-22 10:13:30 UTC

Permalink

Hi Holger,

Post by Holger Levsen
Hi Mike,

I've seen that, discussed it (even highlighted you in that discussion),
thought about it and didnt find any valid reason to have these in place.
Please explain why they are needed.

Sorry, I missed that on IRC...

Post by Holger Levsen
(Oh, and the reason I noticed was that I noticed that the relationship was =
and not >=, which is broken, as it breaks binNMUs. (Which given the way the
package builds, might actually be needed...))

You are correct about the binNMU argument. Please use
"debian-edu-artwork (>= ${source:Version}),

Post by Holger Levsen

Post by Mike Gabriel
debian-edu-artwork (<< ${source:Version}.1)".

So my changed *fixed* something.

Post by Mike Gabriel
Please ask before committing such changes.

Please explain when asking for doing changes ;-P
[18:18] < h01ger> | schweer: sunweaver: or could you see any reasons why
there should be versioned depends?
[18:44] < schweer> | h01ger: unsure, the versioned depends are due to
sunweaver.
[18:45] < h01ger> | i'd understand versioned depends on an specific
version
[18:45] < h01ger> | but on the latest, always? thats already the default
[18:45] < schweer> I guess that's unneeded.
[18:45] < h01ger> | so its just really needed, if it absolutly must be
met, for example for libraries, compilers, data, whatever
[18:46] < h01ger> | but d-e-a-$foo > 0.50 will work nicely with d-e-a a
version less
[18:46] < h01ger> | as i see things
[18:47] < schweer> yes.
[19:12] < h01ger> | so that cleanup was good
So again: why?
cheers,
Holger

1) the dpkg diversion of files are handled by bin:package
debian-edu-artwork (so it is essential that all diversions are in
place before d-e-a-<theme> gets installed).

e.g. debian-edu-artwork-<theme> from 0.49-1 would fail installation
if debian-edu-artwork was still on level 0.48.

2) in the update-debian-edu-artwork-* scripts we test for several
files in debian-edu-artwork (or diverted by debian-edu-artwork) to
exist. If debian-edu-artwork hasn't done its work during
(pre-)installation, the postinst of those other bin:package (-<theme>)
might fail.

Mike
--
DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: ***@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

Holger Levsen

2014-10-22 10:33:05 UTC

Permalink

Hi,

Post by Mike Gabriel
You are correct about the binNMU argument. Please use
"debian-edu-artwork (>= ${source:Version}),

you still haven't convinced me why...

Post by Mike Gabriel
1) the dpkg diversion of files are handled by bin:package
debian-edu-artwork (so it is essential that all diversions are in
place before d-e-a-<theme> gets installed).

yes, a simple depends will make sure this happens.

Post by Mike Gabriel
e.g. debian-edu-artwork-<theme> from 0.49-1 would fail installation
if debian-edu-artwork was still on level 0.48.

yes, but this wont happen. there is only 0.50 in the archive.

Post by Mike Gabriel
2) in the update-debian-edu-artwork-* scripts we test for several
files in debian-edu-artwork (or diverted by debian-edu-artwork) to
exist. If debian-edu-artwork hasn't done its work during
(pre-)installation, the postinst of those other bin:package (-<theme>)
might fail.

yes, so what. there wont be a version lower than 0.50 in the archive.

your versioned dependency doesnt achieve anything which isnt achieved already
anyway. thats why it's not needed. if in future 0.77 really really needs
exactly 0.77, we can introduce a versioned dependency. But *currently* there
is *nothing* in place which makes it needed, that 0.51 needs 0.51. 0.51 will
work fine if a package is from 0.50. Not than this is likely anyway.

So, again: there is no need for a versioned depends. A simple depends is fine.

Because: there are no downgrade. Apt will always choose higher versions.

cheers,
Holger